Install fresh virtualenv on AppVeyor #984
Conversation
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
======================================
Coverage 99.1% 99.1%
======================================
Files 34 34
Lines 2350 2350
Branches 305 305
======================================
Hits 2329 2329
Misses 11 11
Partials 10 10Continue to review full report at Codecov.
|
.appveyor.yml
Outdated
| @@ -102,6 +102,7 @@ matrix: | |||
|
|
|||
| install: | |||
| - "SET PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%" | |||
| - pip install -U virtualenv | |||
There was a problem hiding this comment.
Why not install virtualenv and tox within one line?
I'd prefer you use --update, since it's more human readable.
There was a problem hiding this comment.
It's a workaround and easy to git-blame. Plus tox doesn't need to be upgraded.
Maybe we should better put there a comment about why do we really need to upgrade virtualenv?
There was a problem hiding this comment.
Actual, I prefer long-options too, especially in tests when we run something like invoke(cli, ["--upgrade-package", "foo"]), cause I always forget what does -P mean.
These pip -e -r -U options are so famous and I type them because of a muscle memory 😅 We could normalize all options here and in the other configs in a separate PR. What do you think?
There was a problem hiding this comment.
Also, we can remove this workaround after tox releases a new version, where virtualenv has bumped to >=16.0.0.
|
@codingjoe thanks for reviewing this! |
Fixes #983. See #983 (comment).